1movmedia/pyworker
2
0
Fork 0
Code Pull Requests Activity

redo metrics tracking for requests, fixes bug wherere some requests were marked as pending, even though they had finished (#24)

Browse Source
This commit is contained in:
Nader Arbabian
2025-08-08 17:01:21 -07:00
committed by GitHub
parent e0be45f39a
commit 4016cf9a53
4 changed files with 26 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/metrics.py
+10 -12
View File
@@ -46,33 +46,31 @@ class Metrics:
self.model_metrics.requests_recieved.add(reqnum)
self.model_metrics.requests_working.add(reqnum)
def _request_end(
self, workload: float, req_response_time: float, reqnum: int
) -> None:
def _request_end(self, workload: float, reqnum: int) -> None:
"""
this function is called after a response from model API is received.
this function is called after handling of a request ends, regardless of the outcome
"""
self.model_metrics.workload_served += workload
self.model_metrics.workload_pending -= workload
self.model_metrics.requests_working.discard(reqnum)
self.model_metrics.cur_perf = workload / req_response_time
def _request_success(self, workload: float) -> None:
"""
this function is called after a response from model API is received and forwarded.
"""
self.model_metrics.workload_served += workload
self.update_pending = True
def _request_errored(self, workload: float, reqnum: int) -> None:
def _request_errored(self, workload: float) -> None:
"""
this function is called if model API returns an error
"""
self.model_metrics.workload_pending -= workload
self.model_metrics.workload_errored += workload
self.model_metrics.requests_working.discard(reqnum)
def _request_canceled(self, workload: float, reqnum: int) -> None:
def _request_canceled(self, workload: float) -> None:
"""
this function is called if client drops connection before model API has responded
"""
self.model_metrics.workload_pending -= workload
self.model_metrics.workload_cancelled += workload
self.model_metrics.requests_working.discard(reqnum)
async def _send_metrics_loop(self) -> Awaitable[NoReturn]:
while True: